Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra standart ribbon in plot_erp #238

Closed
vladdez opened this issue Sep 16, 2024 · 6 comments
Closed

Extra standart ribbon in plot_erp #238

vladdez opened this issue Sep 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@vladdez
Copy link
Collaborator

vladdez commented Sep 16, 2024

image

@vladdez vladdez added the bug Something isn't working label Sep 16, 2024
@vladdez vladdez changed the title Extra standart ribbon Extra standart ribbon in plot_erp Sep 16, 2024
@behinger
Copy link
Member

possibly related to:
#55

my guess is that some group/col/row variables are not correctly applied to the ribbon

@vladdez
Copy link
Collaborator Author

vladdez commented Sep 16, 2024

It seems like they have never been applied at all

@behinger
Copy link
Member

possibly easy fix then :)

@behinger
Copy link
Member

but be aware that a mapping*(visual+ribbon) would apply them to both, so that could be a good solution; not sure how it is implemented right now

@vladdez
Copy link
Collaborator Author

vladdez commented Sep 16, 2024

currently it is implemented like this:

    # check if stderror values exist and create new columns with high and low band
    if "stderror" ∈ names(plot_data) && stderror
        plot_data.stderror = plot_data.stderror .|> a -> isnothing(a) ? 0.0 : a
        plot_data[!, :se_low] = plot_data[:, config.mapping.y] .- plot_data.stderror
        plot_data[!, :se_high] = plot_data[:, config.mapping.y] .+ plot_data.stderror
    end
   ...
    if stderror
        m_se = AlgebraOfGraphics.mapping(config.mapping.x, :se_low, :se_high)
        basic = basic + visual(Band, alpha = 0.5) * m_se
    end 

@vladdez
Copy link
Collaborator Author

vladdez commented Sep 16, 2024

fixed in #237

@vladdez vladdez closed this as completed Sep 16, 2024
vladdez added a commit that referenced this issue Sep 24, 2024
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants