Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot_erp legend problem #234

Closed
behinger opened this issue Sep 5, 2024 · 2 comments
Closed

plot_erp legend problem #234

behinger opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@behinger
Copy link
Member

behinger commented Sep 5, 2024

I'm currently getting super werid legends, e.g.
grafik

grafik
@vladdez
Copy link
Collaborator

vladdez commented Sep 6, 2024

which version? probably should be solved in a new update
would be also nice to have MWE

@vladdez vladdez added the bug Something isn't working label Sep 6, 2024
@vladdez
Copy link
Collaborator

vladdez commented Sep 13, 2024

Should be resolved in #237

@vladdez vladdez closed this as completed Sep 13, 2024
@vladdez vladdez mentioned this issue Sep 13, 2024
Merged
vladdez added a commit that referenced this issue Sep 24, 2024
@vladdez
Merge pull request #237 from unfoldtoolbox/splines
b805907 
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
@vladdez vladdez mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behinger @vladdez