Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_legend = false removes not only the legend but also the colorbar in an erp plot #141

Closed
jschepers opened this issue Jan 24, 2024 · 2 comments
Labels
question Further information is requested

Comments

@jschepers
Copy link
Collaborator

In my effects plot, setting show_legend = false not only removed the legend (as intended) but also the colorbar.

Example:

plot_erp(
           effects(Dict(:condition => ["car", "face"], :continuous => -5:5), m);
           mapping = (; color = :continuous, linestyle = :condition, group = :continuous),
           categorical_color = false,
           axis = (xlabel = "Time [s]", ylabel = "Amplitude [μV]"),
           layout = (;show_legend=false),
       );

grafik

@jschepers jschepers added bug Something isn't working question Further information is requested and removed bug Something isn't working labels Jan 24, 2024
@vladdez
Copy link
Collaborator

vladdez commented Sep 17, 2024

we need to depricate show_legend

@vladdez
Copy link
Collaborator

vladdez commented Sep 23, 2024

#237 not deprecated but handled

@vladdez vladdez closed this as completed Sep 23, 2024
vladdez added a commit that referenced this issue Sep 24, 2024
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants