Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable click node to collapse in models view #326

Open
mj3cheun opened this issue Jul 30, 2021 · 3 comments
Open

Disable click node to collapse in models view #326

mj3cheun opened this issue Jul 30, 2021 · 3 comments
Assignees

Comments

@mj3cheun
Copy link
Contributor

Now that the collapse/expand boxes are in place, click parent node to collapse/expand is both unnecessary and causes issues with accidental activation. It should probably be disabled. Please confirm @RosaRomeroGomez.

@RosaRomeroGomez
Copy link
Contributor

Can you describe the issues with activation? You mean with the addition to the params panel and variables panel? Right, we are using double click now for both, however, I still see the value of that feature for large models.

@mj3cheun
Copy link
Contributor Author

Sorry if I wasnt clear, I attached a recording illustrating what i mean. Notice that the button does not appear to have any special click behaviour compared to any other part of the parent node.

Screen.Recording.2021-07-30.at.11.47.42.AM.mov

@RosaRomeroGomez
Copy link
Contributor

Ohhh yes, I enabled it but it seems that expand/collapse function adds that event to the parent container itself. I think we have two options: 1) disable that in the parent; 2) disabled that for the control. We might just go with 2 then.

@RosaRomeroGomez RosaRomeroGomez self-assigned this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants