Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failed and v0.5.1 was not published #88

Closed
teppeis opened this issue Jun 2, 2024 · 6 comments · Fixed by #95
Closed

CI failed and v0.5.1 was not published #88

teppeis opened this issue Jun 2, 2024 · 6 comments · Fixed by #95

Comments

@teppeis
Copy link

teppeis commented Jun 2, 2024

From CI#217, CI failed.
v0.5.1 was not published.

I don't know if this is the cause, but on ubuntu-22.04 with image version 20240403.1.0 or later, the node v16 job is failing to find yarn.

@SunsetTechuila
Copy link

SunsetTechuila commented Jun 8, 2024

From CI#217, CI failed.

this a lint action that was triggered by the pull request, it has nothing to do with releases

v0.5.1 was not published.

it was - https://www.npmjs.com/package/eslint-plugin-import-x/v/0.5.1

I don't know if this is the cause, but on ubuntu-22.04 with image version 20240403.1.0 or later, the node v16 job is failing to find yarn.

see actions/setup-node#1075

@SukkaW
Copy link
Collaborator

SukkaW commented Jun 24, 2024

Yeah, it seems that Node.js 16's corepack can't install yarn. I am going to work on it.

@SunsetTechuila
Copy link

SunsetTechuila commented Jun 24, 2024

Node.js 16's corepack can't install yarn.

No, it is the latest Corepack can't fetch anything because it tries to use Node's built-in fetch, which was only added in Node v18. Why is the latest Corepack being used? Because corepack enable is run before setting up the target Node.

I am going to work on it.

The only solution: actions/setup-node#1075 (comment)

@SukkaW
Copy link
Collaborator

SukkaW commented Jun 25, 2024

@SunsetTechuila

Thanks for providing so many details and context!

Would you like to create a PR to help us fix the CI?

@SunsetTechuila
Copy link

@SukkaW done

@teppeis
Copy link
Author

teppeis commented Jun 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants