Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fixes] #45 | Map dynamic and string convertion issue for iOS fixed #47

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

XeroDays
Copy link
Contributor

@XeroDays XeroDays commented Aug 7, 2024

Issue : #45

This issue was due to the type error, i just changed the string, dynamic to dynamic, dynamic and it works now.

I have read the CLA Document and I sign the CLA

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

This PR primarily involves minor code and formatting refinements for better readability and minor bug fixes in the ultralytics/yolo-flutter-app repository.

📊 Key Changes

  • 🛠️ Reformatted JSON files for iOS app icons and launch images to improve readability.
  • 🧑‍💻 Adjusted type casting in Dart files to ensure proper handling of JSON maps and improve code functionality.

🎯 Purpose & Impact

  • 🚀 Readability: These formatting changes make the code easier to read and maintain, beneficial for both current and future developers.
  • 🐞 Bug Fixes: Correcting type casting helps prevent potential runtime errors, resulting in a more stable application for users.
  • 🧩 Consistency: Consistent formatting across files maintains a uniform codebase, aiding in better collaboration and understanding among contributors.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Minor code enhancements for better type casting and formatting in the YOLO Flutter app.

📊 Key Changes

  • Improved type casting and formatting for JSON parsing in multiple sections of the ultralytics_yolo_platform_channel.dart file.

🎯 Purpose & Impact

  • Consistency: Enhances readability by providing a more consistent code style.
  • Robustness: Ensures tighter type safety, potentially reducing runtime errors for developers.
  • Maintainability: Simplifies future code maintenance and troubleshooting.

Copy link

github-actions bot commented Aug 7, 2024

All Contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@XeroDays
Copy link
Contributor Author

XeroDays commented Aug 7, 2024

recheck

@XeroDays
Copy link
Contributor Author

XeroDays commented Aug 7, 2024

I have read the CLA Document and I sign the CLA

@XeroDays
Copy link
Contributor Author

XeroDays commented Aug 7, 2024

@glenn-jocher Can you assist on approving this PR?

@glenn-jocher
Copy link
Member

Thank you for your contribution!

Before we proceed with the approval, could you please ensure that the issue is reproducible with the latest versions of the packages? This helps us confirm that the fix addresses the current state of the codebase. Once verified, we can move forward with the review process.

Thanks again for your efforts and for being a part of the YOLO community! 😊

@XeroDays
Copy link
Contributor Author

@glenn-jocher This issue is already created and discussed in details here : Issue #45
Please have a look and let me know if you face any confusion.

@glenn-jocher
Copy link
Member

@XeroDays thank you! Introducing some additional Swift formatting here now, then I think we can merge this.

@glenn-jocher glenn-jocher merged commit f512773 into ultralytics:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants