Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making EmailTemplate.name unique #347

Closed
SeiryuZ opened this issue Nov 12, 2020 · 3 comments
Closed

Consider making EmailTemplate.name unique #347

SeiryuZ opened this issue Nov 12, 2020 · 3 comments

Comments

@SeiryuZ
Copy link
Contributor

SeiryuZ commented Nov 12, 2020

We've hit an issue where duplicate EmailTemplate.name crash the mail.send

Should we consider, making EmailTemplate.name unique?

@jrief
Copy link
Collaborator

jrief commented Nov 12, 2020

There is a pull request for this issue: #324

I would like to have one name per natural language for each template (say "Welcome", "Selamat datang", "Bienvenido", etc.) and a machine readable identifier for each template (say "welcome_email").

Apparently we haven't found a consensus about that yet.

@SeiryuZ
Copy link
Contributor Author

SeiryuZ commented Nov 12, 2020

Ah OK. Thanks for the prompt reply on this @jrief !

I'll close this issue as to not split the discussion to here. Thanks again!

@SeiryuZ SeiryuZ closed this as completed Nov 12, 2020
@jrief
Copy link
Collaborator

jrief commented Nov 12, 2020

@SeiryuZ sorry, had a typo in the pull request number above.

Anyway, since you are a maintainer of django-post_office yourself, please have a second look at my pull request #324 , eventually add your comments and/or approve it. I just have seen the the migration files are out of date, hence the unit tests fail. If you agree on my approach, I will fix them as soon as possible in order to create a mergeable pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants