False positive due to nilability of x determined by the value of y

[sonalmahajan15]

NilAway currently doesn't track nilability dependencies between 2 independent variables. This can result in false positives, such as in the example shown below. This is a hard problem, in general. We can perhaps think of adding intra-procedural support, which is a relatively tractable problem, leaving out inter-procedural tracking for the future.

func foo(x *int) {
	var y *int
	var z int

	if x != nil {
		y = x
		z = 1
	}

	if z == 1 {
		_ = *y  // FP reported here
	}
}

func test() {
	i := 1
	foo(&i)
}