Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for nilaway in nvim-lint #255

Open
NormanPerrin opened this issue Jun 7, 2024 · 2 comments
Open

Adding support for nilaway in nvim-lint #255

NormanPerrin opened this issue Jun 7, 2024 · 2 comments

Comments

@NormanPerrin
Copy link

Hello! I wanted to have the nilaway linter output in nvim directly and I didn't know how to integrate it, so I added support to it in nvim-lint.

I understand that this wouldn't be necessary once it's merged with golangci-lint, but in the meantime it'd be nice to have this.
The PR is open if you want to comment on something before it progresses.

Thanks

@yuxincs
Copy link
Contributor

yuxincs commented Jun 8, 2024

Hi @NormanPerrin, thanks for letting us know! It's always great to see contributions from the community 😃

golangci-lint recently added a new plugin mode (since v1.57.0), which made it a lot easier to use NilAway as a private linter in it. We have added documentation in our README: https://github.com/uber-go/nilaway?tab=readme-ov-file#golangci-lint--v1570 , do you think that would help in this case?

With all that being said, kudos to the work on integrating NilAway with nvim-lint

@NormanPerrin
Copy link
Author

@yuxincs I'll investigate further and get back here with the private plugin integration with nvim 👌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants