Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewContinueAsNewError should not "continue" if the context was canceled #935

Open
tscolari opened this issue Feb 7, 2020 · 0 comments
Open
Labels

Comments

@tscolari
Copy link

tscolari commented Feb 7, 2020

I've noticed that the function NewContinueAsNewError(ctx, ...) will not take into consideration that the context it was given was canceled.

I couldn't find this behavior documented anywhere and on slack the suggestion was that this should not happen and to create an issue here.

Would it make sense that if the workflow was canceled (and so the context), NewContinueAsNewError() propagated that CanceledError instead of creating a new error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants