feat: updated notification-list's gotoAction to use fetch when redirect is false #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
requested review from
rmathis,
bjagg,
cbeach47,
cousquer and
jgribonvald
jonathanmtran
force-pushed
the
notification-list/background-action
branch
from
8ed1c42
to
35c00e0
Compare
jonathanmtran
force-pushed
the
notification-list/background-action
branch
2 times, most recently
from
8065624
to
31d846a
Compare
|
Hi @jonathanmtran, can we revisit this one? |
added 2 commits
July 8, 2021 16:10
Defaulting to false since org.jasig.portlet.notice.NotificationAction defaults to false.
jonathanmtran
force-pushed
the
notification-list/background-action
branch
from
31d846a
to
a6754af
Compare
|
Sure thing. I have rebased this branch against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #91