Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Gens for BigDecimal with provided scale #692

Open
larsrh opened this issue Oct 24, 2020 · 1 comment
Open

Expose Gens for BigDecimal with provided scale #692

larsrh opened this issue Oct 24, 2020 · 1 comment

Comments

@larsrh
Copy link
Contributor

larsrh commented Oct 24, 2020

In #670, @non introduced two methods that return Gens with a provided scale:

def chooseBigDecimalScale(minScale: Int): Choose[BigDecimal]
def chooseJavaBigDecimalScale(minScale: Int): Choose[JavaDecimal]

Both of them are private. We should consider making them public.

@ilinandrii
Copy link

Also documntation states:

The implicit instance fixes this value, but since users may want to use other scales we expose this method as well.

but method is not exposed.

As a workaround I think .setScale on a generated BigDecimal should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants