Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorisation don't work #48

Open
gjaekel opened this issue Mar 15, 2021 · 1 comment · May be fixed by #49
Open

Authorisation don't work #48

gjaekel opened this issue Mar 15, 2021 · 1 comment · May be fixed by #49

Comments

@gjaekel
Copy link

gjaekel commented Mar 15, 2021

I'm a newbie to etherpad. I try to get the LDAP integration running. Authenication is already working, but IMHO authentication seems to have an issue:

  • If is false in settings.json, the hook isn't called at all (as seen if loglevel is set to DEBUG).
  • If is set to true, any non-admin get forbidden at the web client.

Is it possible that the value returned at

ep_ldapauth/ep_ldapauth.js

Line 174 in 42cd54c

return cb([false]);

should be true?

Because if I change it in this way, all _seems- to work so far. But I have no experience with Etherpad, yet and this change might be complete wrong.
gjaekel added a commit to gjaekel/ep_ldapauth that referenced this issue Mar 27, 2021
@gjaekel
Update ep_ldapauth.js
b01a6cf 
Authorization don't work because of logical wrong return value.

Closes tykeal#48.
@gjaekel gjaekel linked a pull request Mar 27, 2021 that will close this issue
Open
@pcworld
Copy link

pcworld commented Dec 3, 2021

Maybe try with PR #47 applied. It removes the offending code that you have modified in PR 49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ep_ldapauth.js gjaekel/ep_ldapauth
2 participants
@pcworld @gjaekel