Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: implement PParams blackbox test using Haskell node as test oracle #180

Open
Tracked by #6
scarmuega opened this issue Mar 26, 2024 · 1 comment
Open
Tracked by #6

Comments

@scarmuega
Copy link
Member

scarmuega commented Mar 26, 2024

Context

Correct management of protocol params (aka: PParams) is a complex and essential part of the ledger logic. The easiest way (at the moment) to ensure a correct implementation and detect regressions is by assuming that the output from the Haskell node as our gold-standard.

The current Dolos implementation for PParams management resides here

A hardcoded set of PParams for different epochs and networks is available here. Take these values with a grain of salt, they have been compiled manually and might have inconsistencies.

Goal

We need new unit tests that allows us to compare the output from Dolos' PParams aggregation with well-known values gathered from the chain.

One way to approach this (not mandatory) is to gather the actual blocks from the chain containing param updates and store them as test data in the repo. With use this blocks to execute the PParams aggregation logic in Dolos and then compare the output with the well-known values.

@Quantumplation
Copy link
Contributor

👋 I'm going to tackle this, if you want to assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants