Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the "janky" max health attribute by utilizing a potion effect instead? #25

Open
DannyDoesGraphics opened this issue Apr 10, 2024 · 1 comment
Open

Resolve the "janky" max health attribute by utilizing a potion effect instead? #25

DannyDoesGraphics opened this issue Apr 10, 2024 · 1 comment

Comments

@DannyDoesGraphics
Copy link

Right now the set attribute max health feature conflicts with a lot of mods that may increase the user's hp. I propose we resolve this issue by applying a potion effect. A MVP could just be applying the pre-existing health boost.
@DannyDoesGraphics
Copy link
Author

If I have time after my finals, I'll look into implementing this myself and doing a PR.

@Zoruea Zoruea mentioned this issue Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DannyDoesGraphics