Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of marbles \times unittest #73

Open
thejunglejane opened this issue Jun 7, 2018 · 0 comments
Open

Improve test coverage of marbles \times unittest #73

thejunglejane opened this issue Jun 7, 2018 · 0 comments
Assignees
Labels

Comments

@thejunglejane
Copy link
Contributor

marbles itself is fairly comprehensively tested, in terms of lines and also features, but we don't very well test how marbles interacts with all of the features of unittest. For example, some of the assertions we're wrapping in marbles may behave strangely depending on how we've wrapped them (we've seen problems before where things like assertMultiLineEqual don't faithfully pass the msg argument to all assertions they then make, which broke our annotations, but only when that method got called with something that wasn't a str).

We should try to test marbles against all assertions in unittest, possibly by running unittest's own test harnesses. We may also want to test interactions between marbles and other features of unittest, but let's start there.

@thejunglejane thejunglejane self-assigned this Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant