Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam backend is missing some pipes #1979

Open
johnynek opened this issue Mar 20, 2022 · 0 comments
Open

Beam backend is missing some pipes #1979

johnynek opened this issue Mar 20, 2022 · 0 comments

Comments

@johnynek
Copy link
Collaborator

[warn] /Users/oscar/code/oss/scalding/scalding-beam/src/main/scala/com/twitter/scalding/beam_backend/BeamBackend.scala:29:27: match may not be exhaustive.
[warn] It would fail on the following inputs: (CounterPipe(_), _), (CrossPipe(_, _), _), (CrossValue(_, _), _), (DebugPipe(_), _), (EmptyTypedPipe, _), (ForceToDisk(_), _), (TrappedPipe(_, _), _), (WithOnComplete(_, _), _)
[warn]       def toFunction[A] = {
[warn]                           ^
[warn] one warning found

Those need to be added to otherwise you will have errors at runtime. I think all of them are pretty simple to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant