Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 issues #33

Closed
cwuensche opened this issue Feb 10, 2020 · 2 comments
Closed

PHP 7.4 issues #33

cwuensche opened this issue Feb 10, 2020 · 2 comments

Comments

@cwuensche
Copy link

You have many instances where you're accessing the array using curly braces.

Fix: Replace the {} with [] when you're accessing array elements.

$ascii .= '\\'.$var{$c};

@twisted1919
Copy link
Owner

Thanks for pointing out, i'll leave this open to check for more occurrences tomorrow when at work.
If you find anything else, let me know.

@twisted1919
Copy link
Owner

I think this has been taken care of in 1.0.7. We added phpstan for checking and also started adding tests, hopefully will catch such things in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants