Fix array edit option #8600
Fix array edit option #8600
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for editing Array type fields in the MultiItemFieldInput component, fixing an error that occurred when attempting to edit Array type values.
- Added
FieldMetadataType.Arraycase inhandleEditButtonClickmethod in/packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/MultiItemFieldInput.tsx - Array type values are now handled similarly to Email types, treating them as strings
- Consider adding type safety checks when casting Array values to strings
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -110,6 +110,7 @@ export const MultiItemFieldInput = <T,>({ | |||
| item = items[index] as PhoneRecord; | |||
| setInputValue(item.countryCode + item.number); | |||
| break; | |||
| case FieldMetadataType.Array: | |||
There was a problem hiding this comment.
Why is there no break condition for this? is the break condition for emails and arrays the same?
There was a problem hiding this comment.
Yes, the break statement for Array and Email are the same. The way the Array is being handled in the backend is just like the Email. So I found it better to use the same block as the Email one
|
Hey @ehconitin, could you review this please? |
|
There is an explicit break for the Array though. If it applies for Email, won't it also apply for Array |
Closes #8578
There was no case to handle a
FieldMetadataType.Arrayand thus an error was thrown every time the edit button was clicked on anArraytype.It has been added now.