-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals aria-hidden attribute #41005
Comments
A bit more on this - I'm thinking it is a rising issue This only occurs when the fade class is set, so it is to do with elements having focus and visible when the aria attribute is set Is it sensible to move the setting of the aria hidden attribute down to after the css transition has taken place ? This file is js/dist/modal.js |
It is a rising issue; the same thing happens in Google Chrome (Canary Version 133.0.6840.0). The issue occurs when the |
In my previous comment, I mentioned that the issue occurs when the |
I don't know enough to definitively associate it with fade - but am associating it with something retaining focus until after the transition between the events hide.bs.modal and hidden.bs.modal - so have blamed fade I guess but it is random - it exists in bootstrap 4 too In a modified bootstrap.js it disappears for me when the aria-hidden line is moved down |
Prerequisites
Describe the issue
I'm actually using Brave Beta - Chrome 131.0.6778.14 Beta, checking around this issue seems to be in Beta and Nightly builds; but not the current release
I tested on Chrome beta - same version as my Brave and it exists there
I'm concluding it is an imminent issue
I can see this got mentioned a while back in #29769
The Issue:
I've started seeing aria-hidden issues when I close my modals, and have been able to see it on the demo modals at https://getbootstrap.com/docs/5.3/components/modal/
So to replicate the issue I open the modal, then close it using the cross (top right in the modal header)
a second or so after the click this appears in the console, I hadn't noticed before today
I've gone back over my code and am consistent with the documentation
Reduced test cases
The issue exists in my code and can be demonstrated on the getbootstrap.com site
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.3.3
The text was updated successfully, but these errors were encountered: