Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover arrow doesn't match the header background if placement is bottom #40993

Open
3 tasks done
xvaara opened this issue Oct 29, 2024 · 1 comment · May be fixed by #40994
Open
3 tasks done

Popover arrow doesn't match the header background if placement is bottom #40993

xvaara opened this issue Oct 29, 2024 · 1 comment · May be fixed by #40994

Comments

@xvaara
Copy link

xvaara commented Oct 29, 2024

Prerequisites

Describe the issue

Popover arrow doesn't match the header background if placement is bottom.

There is a potential fix using variables:

.bs-popover-auto[data-popper-placement^='bottom'] .popover-arrow:has(+ .popover-header)::after,
.bs-popover-bottom .popover-arrow:has(+ .popover-header)::after {
  --bs-popover-bg: var(--bs-popover-header-bg);
}

Reduced test cases

https://stackblitz.com/edit/wb5ais?file=index.html

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

No response

What version of Bootstrap are you using?

5.3

@julien-deramond
Copy link
Member

julien-deramond commented Oct 29, 2024

Good catch, @xvaara—thanks for reporting this issue! Your workaround looks promising at first glance, especially in terms of rendering. It makes sense that it would work that way. I see that it relies on :has, which Bootstrap doesn’t support yet. Let's explore what we can do in a PR to address this!

Edit: see #40994

@julien-deramond julien-deramond moved this from To analyze to To do in v5.3.4 Oct 29, 2024
@julien-deramond julien-deramond moved this from To do to Needs review in v5.3.4 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging a pull request may close this issue.

2 participants