Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject invalid gitosis configurations #9

Open
lazytyper opened this issue Aug 26, 2015 · 2 comments
Open

Reject invalid gitosis configurations #9

lazytyper opened this issue Aug 26, 2015 · 2 comments

Comments

@lazytyper
Copy link

If you push an update of gitosis-admin with an invalid gitosis.conf file, you can't access any repositories anymore, you will always receive a ConfigParser.ParsingError until you fix the gitosis,conf on the server.

There should be a protection:
When the gitosis-admin repository receives an update, the gitosis.conf should be checked if it is still valid, if not, then the update should be rejected.

@tv42
Copy link
Owner

tv42 commented Aug 26, 2015

Unfortunately, "valid" is not a criteria that can be programmed reasonably. What if you accidentally replaced your ssh public key with the key of a stranger?

The only fix that works in all circumstances is to log in to the box and undo the damage. Sorry.

@xundeenergie
Copy link

You mean a check like visudo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants