Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tab rename to be TUI #289

Closed
wants to merge 2 commits into from

Conversation

eyal-sasson
Copy link
Contributor

Close #286.

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for terminal7 ready!

Name Link
🔨 Latest commit 1b00895
🔍 Latest deploy log https://app.netlify.com/sites/terminal7/deploys/6335417d0e72c100086d5f24
😎 Deploy Preview https://deploy-preview-289--terminal7.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@daonb
Copy link
Contributor

daonb commented Sep 29, 2022

Running on the iPad, when I try to rename nothing happens.
In the browser console I see an error:

[Error] Unhandled Promise Rejection: Error: aborted promiseEmptyOnRejected (form.ts:247) promiseReactionJob

@eyal-sasson
Copy link
Contributor Author

About the error - I simply forgot a catch statement, easily fixable.
Problem is the form is being aborted if clicking for too long as it triggers the t7.onClick event which closes the log. Not sure what to do about it as the long press is handled by Hammer and I am not familiar with its usage.

@daonb
Copy link
Contributor

daonb commented Jan 16, 2023

The UI doesn't look good

@daonb daonb closed this Jan 16, 2023
@eyal-sasson eyal-sasson deleted the rename-tui branch January 21, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "rename <tab|gate> [name]" command
2 participants