Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] volsync template issue #30469

Closed
3 tasks done
spagno opened this issue Dec 30, 2024 · 0 comments · Fixed by #30470
Closed
3 tasks done

[common] volsync template issue #30469

spagno opened this issue Dec 30, 2024 · 0 comments · Fixed by #30470
Labels
bug Something isn't working

Comments

@spagno
Copy link
Contributor

spagno commented Dec 30, 2024

Chart Name

common

Operating System

other

Deployment Method

FluxCD

Chart Version

25.2.5

Kubernetes Events

-

Chart Logs

❯ k -n media get hr autobrr
NAME      AGE     READY   STATUS
autobrr   3d11h   False   Could not determine release state: unable to determine cluster state: ReplicationSource/media/autobrr-config-b2 dry-run failed: failed to create typed patch object (media/autobrr-config-b2; volsync.backube/v1alpha1, Kind=ReplicationSource): .spec.restic.cleanupCachePVC: field not declared in schema

Chart Configuration

---
    persistence:
      config:
        enabled: true
        readOnly: false
        size: 10Gi
        static:
          mode: disabled
        storageClass: ""
        targetSelector:
          exportarr:
            exportarr:
              mountPath: /config
              readOnly: true
          main:
            main:
              mountPath: /config
        type: pvc
        volsync:
          - name: b2
            type: restic
            credentials: s3
            dest:
              enabled: true
            src:
              enabled: true
              trigger:
                schedule: "0 */1 * * *"
---

Describe the bug

#29830 added cleanupTempPVC: false and cleanupCachePVC: false as default fields for the charts/library/common/templates/class/volsync/_replicationSource.tpl file but the CRD defined in #30427 doesn't have this fields in the object.

This causes the error "field not declared in schema"

To Reproduce

  1. add a chart using volsync with restic

Expected Behavior

helmreleases reconcile without error

Screenshots

immagine

Additional Context

I've read and agree with the following

  • I've checked all open and closed issues and my issue is not there.
  • I've understand TrueNAS SCALE Apps are deprecated and TrueCharts does not accept TrueNAS SCALE related issues
  • I've prefixed my issue title with [Chart-Name]
@spagno spagno added the bug Something isn't working label Dec 30, 2024
@spagno spagno changed the title [common]: volsync issue [common] volsync template issue Dec 30, 2024
stavros-k added a commit that referenced this issue Dec 30, 2024
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->
⚒️ Fixes  #30469 

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [x] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [x] ⚖️ My code follows the style guidelines of this project
- [x] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [x] ⚠️ My changes generate no new warnings
- [x] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning
- [x] I made sure the title starts with `feat(chart-name):`,
`fix(chart-name):` or `chore(chart-name):`

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant