Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosearch not working on Firefox #224

Open
JusticeAU opened this issue Nov 2, 2024 · 0 comments
Open

Autosearch not working on Firefox #224

JusticeAU opened this issue Nov 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JusticeAU
Copy link

Describe the bug
The AutoSearch jquery is not running when loading the Sonarr and Radarr pages

To Reproduce

  1. Perform a search through any means (Radarr/Sonarr button on IMDB, RottonTomatos, TBDB, highlighted text)
  2. Have Sonarr or Radarr load with the URL populated with the search term
  3. Note that the auto search does not kick in
  4. The search box is empty, but the URL is populated with the search term.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version: 132..0
  • Extension version 2.9.0.0

Notes:

I did some debugging myself and found the following information:

Browser console reports:
"TypeError: browser.tabs is undefined"
image

This person has the same or similar issue: https://www.reddit.com/r/radarr/comments/1gfk4cx/adding_new_movie_via_http_path_name

This post reports that for Firefox, to access browser.tabs - the loaded script should be in "background" rather than "content_scripts" in the manifest : https://stackoverflow.com/questions/55022508/browser-tabs-is-undefined-in-firefox-extension

Making the change locally myself fixes the issue for me, but I am not familiar with Firefox extension development, nor open source pull request flows.

Happy to create a fork and submit a PR that moves the the file path from content_scripts to background, if you feel that's a solid fix for this.

@JusticeAU JusticeAU added the bug Something isn't working label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants