Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted Bombard Casualties Firing Back #8948

Closed
DanVanAtta opened this issue Mar 1, 2021 · 4 comments · Fixed by #11791
Closed

Restricted Bombard Casualties Firing Back #8948

DanVanAtta opened this issue Mar 1, 2021 · 4 comments · Fixed by #11791
Assignees
Labels
2.6 Major Indicates the problem is very impactful, very noticable, no work around Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release

Comments

@DanVanAtta
Copy link
Member

Reproduction Steps

  1. open attached save game
  2. click 'done' to end purchase turn
  3. say 'yes' for units to bombard, battle will then auto-start
  4. notice in the first round of combat that the defender fires back

Expected: defender should not fire back, bombard casualty should be removed immediately

Attach a Save Game

restricted-bombard-firing-back.tsvg.zip

Engine Version

Engine Version: 2.6 @ e1cf9ee

Is there anything else we should know?

@DanVanAtta DanVanAtta added Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release labels Mar 1, 2021
@stale
Copy link

stale bot commented Aug 28, 2021

I noticed there has not been much activity on this issue. Please check this issue and close it if it no longer applies.
Otherwise to help move this issue move forward, please add a comment summarizing any further actions that need to be taken in order to resolve this issue.

@stale stale bot added the Stale label Aug 28, 2021
@DanVanAtta DanVanAtta removed the Stale label Oct 27, 2022
@asvitkine asvitkine added 2.6 Major Indicates the problem is very impactful, very noticable, no work around labels Jul 15, 2023
@asvitkine asvitkine self-assigned this Jul 15, 2023
@asvitkine
Copy link
Contributor

I actually get an NPE with the above saved game. Will investigate.

@Cernelius
Copy link
Contributor

For general information, this is also related to an old problem.

V1 (Classic) being the default for TripleA, naval bombard casualties should fire back as default (like if I make a map with no properties at all in the game XML file), whereas TripleA has naval bombard casualties fire back disallowed as default and a property for allowing them to fire back (which is the exact opposite of how it should be).

For general information, naval bombard casualties fire back in v1 as well as in all rule-sets from v3 onwards and do not fire back in v2 only.

@Cernelius
Copy link
Contributor

I actually get an NPE with the above saved game. Will investigate.

Same for me. I reported it here:
#11784

asvitkine added a commit to asvitkine/triplea-1 that referenced this issue Jul 19, 2023
A parameter was missing!
Adds a test.
Fixes: triplea-game#8948
asvitkine added a commit that referenced this issue Jul 19, 2023
A parameter was missing!
Adds a test.
Fixes: #8948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.6 Major Indicates the problem is very impactful, very noticable, no work around Problem A problem, bug, defect - something to fix Regression A problem introduced in pre-release and not present in latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants