Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameMap#getNeighbors:102 - java.lang.IllegalArgumentException #12822

Open
tripleabuilderbot opened this issue Aug 6, 2024 · 4 comments
Open
Assignees
Labels
2.7 Error Report Issue reported via the in-game error reporter IllegalArgumentException java.lang.IllegalArgumentException

Comments

@tripleabuilderbot
Copy link
Contributor

User Description

Was in between human turns during Zombie research phase, it keeps popping an exception that null has no neighbor

Map

Zombies-World_War_2 / Zombies-World_War_2

Log Message

No neighbors for: null

TripleA Version

2.7.14834

Java Version

11.0.19

Operating System

Windows 11

Heap Size

8152M

Stack Trace

Exception: java.lang.IllegalArgumentException No neighbors for: null
java.lang.Exception
	at games.strategy.engine.data.GameMap.getNeighbors(GameMap.java:102)
	at games.strategy.engine.data.GameMap.getNeighbors(GameMap.java:119)
	at games.strategy.engine.data.GameMap.getNeighbors(GameMap.java:113)
	at games.strategy.triplea.ai.pro.ProTechAi.findFrontier(ProTechAi.java:617)
	at games.strategy.triplea.ai.pro.ProTechAi.getExactNeighbors(ProTechAi.java:600)
	at games.strategy.triplea.ai.pro.ProTechAi.getNeighboringLandTerritories(ProTechAi.java:579)
	at games.strategy.triplea.ai.pro.ProTechAi.tech(ProTechAi.java:50)
	at games.strategy.triplea.ai.pro.AbstractProAi.tech(AbstractProAi.java:308)
	at games.strategy.triplea.ai.AbstractAi.start(AbstractAi.java:512)
	at games.strategy.engine.framework.ServerGame.waitForPlayerToFinishStep(ServerGame.java:611)
	at games.strategy.engine.framework.ServerGame.runStep(ServerGame.java:460)
	at games.strategy.engine.framework.ServerGame.runNextStep(ServerGame.java:347)
	at games.strategy.engine.framework.ServerGame.startGame(ServerGame.java:314)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.launchInternal(LocalLauncher.java:92)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.lambda$launch$0(LocalLauncher.java:60)
	at java.base/java.lang.Thread.run(Thread.java:829)


@tripleabuilderbot tripleabuilderbot added 2.7 Error Report Issue reported via the in-game error reporter labels Aug 6, 2024
@EduardoPantalones
Copy link

Not sure I was logged in when I opened this

@beelee1
Copy link
Contributor

beelee1 commented Aug 6, 2024

@EduardoPantalones

Do you know if it does it with the 2.5 stable and if not, maybe check the last 2.6 prrelease and see it it happens there ?

@EduardoPantalones
Copy link

@EduardoPantalones

Do you know if it does it with the 2.5 stable and if not, maybe check the last 2.6 prrelease and see it it happens there ?

I do not, if it happens again I will look at that for you. The workaround was to save, make Zombies Human and reload, and then switch them back to AI after their turn, we are 3 turns past event now. weird scenario :) Thanks for quick response!

@frigoref
Copy link
Member

Should be fixed with PR 12831 (Fix issue 12822 GameMap#getNeighbors IllegalArgumentException).
@EduardoPantalones Please confirm that on the map the issue is no longer experienced.
Only hint I have is that it seemed to have been cause for cases where no "capitol" territory was passed on the search for neighbors. Not sure how exactly the setup had been or how to retest it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 Error Report Issue reported via the in-game error reporter IllegalArgumentException java.lang.IllegalArgumentException
Projects
None yet
Development

No branches or pull requests

4 participants