ProNonCombatMoveAi#visit:2415 - java.lang.NullPointerException

[tripleabuilderbot]

Map

another_world

TripleA Version

2.6.14364

Java Version

11.0.9.1

Operating System

Windows 10

Stack Trace

Exception: java.lang.NullPointerException 
java.lang.Exception
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi$1.visit(ProNonCombatMoveAi.java:2415)
	at games.strategy.engine.data.util.BreadthFirstSearch.checkNextTerritory(BreadthFirstSearch.java:88)
	at games.strategy.engine.data.util.BreadthFirstSearch.traverse(BreadthFirstSearch.java:71)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.findDestinationOrSafeTerritoryOnTheWay(ProNonCombatMoveAi.java:2407)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.moveConsumablesToFactories(ProNonCombatMoveAi.java:2367)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.moveInfraUnits(ProNonCombatMoveAi.java:2256)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.doNonCombatMove(ProNonCombatMoveAi.java:184)
	at games.strategy.triplea.ai.pro.ProNonCombatMoveAi.simulateNonCombatMove(ProNonCombatMoveAi.java:77)
	at games.strategy.triplea.ai.pro.AbstractProAi.purchase(AbstractProAi.java:215)
	at games.strategy.triplea.ai.AbstractAi.start(AbstractAi.java:508)
	at games.strategy.engine.framework.ServerGame.waitForPlayerToFinishStep(ServerGame.java:593)
	at games.strategy.engine.framework.ServerGame.runStep(ServerGame.java:450)
	at games.strategy.engine.framework.ServerGame.runNextStep(ServerGame.java:345)
	at games.strategy.engine.framework.ServerGame.startGame(ServerGame.java:312)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.launchInternal(LocalLauncher.java:92)
	at games.strategy.engine.framework.startup.launcher.LocalLauncher.lambda$launch$0(LocalLauncher.java:60)
	at java.base/java.lang.Thread.run(Thread.java:834)

[asvitkine]

NPE is on this line:

                if (moveMap.get(r.getEnd()).isCanHold() && validateMove.test(r)) {

I assume moveMap.get() is returning null? We could add a simple guard, but there must be a deeper underlying issue...

[asvitkine]

moveMap comes from territoryManager.getDefendOptions().getTerritoryMap();

I guess an issue could be that we're using the wrong moveMap here - i.e. if defendOptions is only populated with territories that can be defended by the AI's units, whereas here we're choosing a path for infra (non-defensive) units.

I will try to see if I can make a repro for this with edit mode.