Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review me? #1

Open
cmcaine opened this issue Jul 9, 2017 · 9 comments
Open

Review me? #1

cmcaine opened this issue Jul 9, 2017 · 9 comments

Comments

@cmcaine
Copy link
Member

cmcaine commented Jul 9, 2017

@kmaglione

Back in April I was talking to you a fair amount about this proposed API, and you said you'd be willing to review it when I'd gotten it to a reasonable state. Is that offer still open?

This is a simple first version with fairly limited functionality. I'd appreciate if you could take a look at it and see if I'm on the right tracks.

Thanks!

Comments from others also welcome :)

@tgy
Copy link

tgy commented Oct 1, 2017

Thank you for your work. You're currently my only hope of having a functional vimperator-like user experience on FF58! Keep it up 👍

@ghost
Copy link

ghost commented Oct 11, 2017

@cmcaine I see no feedback from Mozilla here. And saw you have updated code 15 days before. What is the latest progress about this api? Did Mozilla developers say something about it?

@cmcaine
Copy link
Member Author

cmcaine commented Oct 11, 2017

@wnereiz Mozilla devs are busy with FF57, but Andy Mckay (webextensions team leader or something?) says he'll get mentors for our bugs soon.

The meta bug (previously the bug mainly for the project in this repo) is: https://bugzilla.mozilla.org/show_bug.cgi?id=1215061

The key-sequence parser I'm developing for tridactyl will also go in the keyboard API to power the stopPropagation/preventDefault stuff.

The bug for the shortcut API is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1403295

On that last one you can see some complaints about how we intended to have the API work. We're blocked on the shortcut part of the API until they'll talk to us about it.

@ghost
Copy link

ghost commented Oct 12, 2017

@cmcaine I checked both bugs, and it is really a long story. I'll read the details later. Thank you very much for the efforts on it.

@ghost
Copy link

ghost commented Feb 26, 2018

Looks like the first step is finished (provide a way for an extension to update the shortcut for its command): https://bugzilla.mozilla.org/show_bug.cgi?id=1421811

@aspel
Copy link

aspel commented May 10, 2018

@bovine3dom
Copy link
Member

@aspel unfortunately, that's for Emacs style octopus commands (just look at the examples: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands) rather than the vim-style sequence of commands, which is what we want, but this API makes no assumptions about what you want to do with the keys:

The idea of this API is that we would be able to capture key events across the entire browser and send them to a background script.

@ghost
Copy link

ghost commented Oct 5, 2018

@cmcaine It is another year passed. I haven't see any progress on that. What is your comments on above commands API? Is it possible to be used for the addons like tridactyl?

@bovine3dom
Copy link
Member

The comment above yours explains why we can't use the commands API.

@cmcaine seems to have lost interest in pursuing this API so if you want to take it up I'm sure he'd be happy for you to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants