Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for imagePullSecrets #184

Open
crburke opened this issue Jun 16, 2023 · 3 comments
Open

Add support for imagePullSecrets #184

crburke opened this issue Jun 16, 2023 · 3 comments

Comments

@crburke
Copy link

crburke commented Jun 16, 2023

The deployment.yaml file does not support specification of imagePullSecrets.

This is useful for scenarios where this chart is used as a dependency by another chart that includes altering the target image to be used by the deployment.

@N-o-Z
Copy link
Member

N-o-Z commented Jun 21, 2023

@crburke Thank you for your contribution. Can you expand a little bit more about your use case?

@crburke
Copy link
Author

crburke commented Jun 21, 2023

We have internal tooling to support adding an internal certificate authority to a docker image. To leverage that tooling I needed to build a custom lakeFS image. Once that image was available I wanted to continue using the helm charts provided in this repo, but I needed to be able to provide imagePullSecrets to be able to access the image from our docker registry. To do so I changed lakefs/templates/deployment.yaml to include the following in the spec section, but ideally this would be supported by the chart without any further customization:

{{- if .Values.imagePullSecret }}
imagePullSecrets:
  - name: {{ .Values.imagePullSecret }
{{- end }}

@sverbruggen
Copy link

I would also appreciate this function being added to the chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants