Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't exit travis monitor if a server error happens #126

Closed
sarahhodne opened this issue Oct 28, 2013 · 3 comments
Closed

Don't exit travis monitor if a server error happens #126

sarahhodne opened this issue Oct 28, 2013 · 3 comments

Comments

@sarahhodne
Copy link
Contributor

Right now, if Pusher or our API throws a 500 error, travis monitor will just exit. In the case of a Pusher error, we should probably reconnect to the stream, and maybe retry (or silently ignore) if our API errors?

@rkh
Copy link
Contributor

rkh commented Oct 28, 2013

👍

related: pusher-community/pusher-websocket-ruby#23

@Habbie
Copy link
Contributor

Habbie commented Nov 5, 2013

I found my "travis monitor" eating all of one CPU core. Last output:

2013-11-05 14:51:19 PowerDNS/pdns#1048.2 passed
2013-11-05 14:51:28 PowerDNS/pdns#1048 passed
2013-11-05 14:51:28 PowerDNS/pdns#1048.1 passed
F, [2013-11-05T16:22:50.369657 #28937] FATAL -- : Pusher : error : {"code"=>4200, "message"=>"Please reconnect immediately"}

so +1 on pusher-community/pusher-websocket-ruby#23 affecting travis I guess.

@rkh
Copy link
Contributor

rkh commented Nov 6, 2013

It did? Hmm… I've never seen that happen. Curious as to why it would go crazy on CPU if the pusher connection is lost.

@rkh rkh closed this as completed in 68c0297 Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants