Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how service ports are filtered in the provider #545

Open
kevinpollet opened this issue May 4, 2020 · 0 comments
Open

Rework how service ports are filtered in the provider #545

kevinpollet opened this issue May 4, 2020 · 0 comments
Milestone

Comments

@kevinpollet
Copy link
Member

Proposal

The provider uses the topology to build the dynamic configuration that will be fetched by the proxy nodes. During this step, only ports with a suitable protocol corresponding to the service traffic type should be added to the generated dynamic configuration.

Currently, the tcp and udp port mappers are used to achieve this filtering which is not optimal and leads to unwanted errors in the logs. It also seems that no filtering is done for HTTP services.

This code should be reworked to fix unwanted errors and potential issues.

@kevinpollet kevinpollet added this to the v1.4 milestone Jul 9, 2020
@kevinpollet kevinpollet modified the milestones: v1.4, next Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant