Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexedfs: implement Rename for directories #113

Open
Parzival-3141 opened this issue Mar 1, 2024 · 1 comment
Open

indexedfs: implement Rename for directories #113

Parzival-3141 opened this issue Mar 1, 2024 · 1 comment

Comments

@Parzival-3141
Copy link
Collaborator

Parzival-3141 commented Mar 1, 2024

// TODO: handle case where oldname and newname are directories.

With current behavior, renaming a directory only moves the root directory file and not it's children.

@progrium
Copy link
Contributor

progrium commented Apr 1, 2024

We might want to change the schema from just a path to a name and a parent ID. This would make move/rename operations not need to change children. The tradeoff would be path lookups would be slower, but we can always cache them in memory. As long as we are careful to expire all the child paths on a move...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants