Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPT-1332] Separate validation from QueryBuilder implementation #4566

Merged
merged 7 commits into from
Sep 25, 2024
Merged

[CPT-1332] Separate validation from QueryBuilder implementation #4566

merged 7 commits into from
Sep 25, 2024

Conversation

toptalwadiibasmi
Copy link
Contributor

@toptalwadiibasmi toptalwadiibasmi commented Sep 18, 2024 •
edited
Loading

CPT-1332

Description

  • We separate validation implementation from QueryBuilder component's
  • Replace customValueEditor with to valueEditor

How to test

  • Temploy
  • No regression in QueryBuilder in Picasso stories
  • No regression in staff portal using the alpha package.

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@toptalwadiibasmi toptalwadiibasmi requested a review from a team September 18, 2024 13:56
@toptalwadiibasmi toptalwadiibasmi self-assigned this Sep 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b02e681

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-query-builder Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptalwadiibasmi toptalwadiibasmi force-pushed the CPT-1332-fe-externalize-validation-again-in-picasso-query-builder branch from d7822f3 to baea90b Compare September 18, 2024 14:12
@toptalwadiibasmi
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@56.0.5-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/base-tailwind@1.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.8+baea90bfe
yarn add @toptal/picasso@52.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-accordion@3.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-account-select@3.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-alert@3.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-amount@1.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-application-update-notification@2.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-autocomplete@5.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-avatar@6.1.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-avatar-upload@3.0.11-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-backdrop@1.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-badge@3.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-breadcrumbs@3.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-button@4.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-calendar@4.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-carousel@4.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-charts@59.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-checkbox@5.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-codemod@6.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.264+baea90bfe
yarn add @toptal/picasso-collapse@3.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-container@3.1.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/picasso-date-picker@3.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-date-select@1.0.56-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-drawer@3.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-dropdown@4.1.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-dropzone@5.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-empty-state@2.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-environment-banner@3.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.59+baea90bfe
yarn add @toptal/picasso-fade@1.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-file-input@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-form@6.1.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-forms@73.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-grid@5.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-helpbox@5.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-icons@1.7.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-image@3.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-input@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-input-adornment@3.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-link@3.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.17+baea90bfe
yarn add @toptal/picasso-list@5.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-loader@3.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-logo@2.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-menu@3.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-modal@3.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-modal-context@1.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.323+baea90bfe
yarn add @toptal/picasso-note@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/picasso-notification@4.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-number-input@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-outlined-input@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-overview-block@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/picasso-page@5.1.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-pagination@4.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-paper@4.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-password-input@5.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-pictograms@5.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-popper@1.0.5-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-prompt-modal@2.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-provider@5.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.142+baea90bfe
yarn add @toptal/picasso-query-builder@7.2.16-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-quote@2.0.5-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/picasso-radio@5.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-rating@3.0.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-rich-text-editor@17.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-section@5.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-select@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-shared@15.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.221+baea90bfe
yarn add @toptal/picasso-show-more@2.0.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-skeleton-loader@1.0.45-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-slide@1.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-slider@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-step@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-switch@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-table@3.0.9-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-tabs@5.0.5-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-tag@4.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-tagselector@3.1.8-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-tailwind@3.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.8+baea90bfe
yarn add @toptal/picasso-tailwind-merge@2.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-test-utils@1.1.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.221+baea90bfe
yarn add @toptal/picasso-timeline@5.0.3-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.20+baea90bfe
yarn add @toptal/picasso-timepicker@4.0.7-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-tooltip@2.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-tree-view@3.0.20-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.4+baea90bfe
yarn add @toptal/picasso-typography@4.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-typography-overflow@4.0.2-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe
yarn add @toptal/picasso-user-badge@5.1.4-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.6+baea90bfe
yarn add @toptal/picasso-utils@2.0.1-alpha-CPT-1332-fe-externalize-validation-again-in-picasso-query-builder-baea90bfe.27+baea90bfe

@toptalwadiibasmi toptalwadiibasmi marked this pull request as ready for review September 23, 2024 13:42
@toptalwadiibasmi toptalwadiibasmi requested a review from a team as a code owner September 23, 2024 13:42
@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Sep 23, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @toptalwadiibasmi 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@toptalwadiibasmi toptalwadiibasmi force-pushed the CPT-1332-fe-externalize-validation-again-in-picasso-query-builder branch from baea90b to 39a22f8 Compare September 23, 2024 13:43
sashuk
sashuk approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@sashuk
Copy link
Contributor

sashuk commented Sep 23, 2024

@toptal-anvil ping reviewers

@rasitozcan
Copy link
Contributor

Temploy link was removed, added it again, I see an issue on CustomValueEditor example (it throws an error)

@toptalwadiibasmi
Copy link
Contributor Author

@toptal-bot run package:alpha-release

rasitozcan
rasitozcan approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@rasitozcan rasitozcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

angelinastavniiciuc
angelinastavniiciuc approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@angelinastavniiciuc angelinastavniiciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not checked manually tho

@toptalwadiibasmi toptalwadiibasmi merged commit a6d5828 into master Sep 25, 2024
21 of 28 checks passed
@toptalwadiibasmi toptalwadiibasmi deleted the CPT-1332-fe-externalize-validation-again-in-picasso-query-builder branch September 25, 2024 13:29
@toptal-build toptal-build mentioned this pull request Sep 25, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashuk sashuk sashuk approved these changes

@rasitozcan rasitozcan rasitozcan approved these changes

@angelinastavniiciuc angelinastavniiciuc angelinastavniiciuc approved these changes

Assignees

@toptalwadiibasmi toptalwadiibasmi

Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toptalwadiibasmi @toptal-devbot @sashuk @rasitozcan @angelinastavniiciuc