Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5151] Fix padding for collapsible bordered Section #4559

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Sep 17, 2024

FX-5151

Description

Override spacing of bordered collapsible Sections, to better follow BASE design

How to test

  • Temploy
  • Check temploy and Happo screenshots

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura self-assigned this Sep 17, 2024
@augustobmoura augustobmoura requested a review from a team as a code owner September 17, 2024 02:22
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: e52fa03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-section Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected, left a NIT comment in https://github.com/toptal/picasso/pull/4559/files#r1762816744

Kapture.2024-09-17.at.10.31.14.mp4

@sashuk sashuk requested a review from a team September 17, 2024 09:32
@sashuk
Copy link
Contributor

sashuk commented Sep 17, 2024

@toptal-anvil ping reviewers

@augustobmoura augustobmoura enabled auto-merge (squash) September 18, 2024 03:59
@augustobmoura augustobmoura force-pushed the fx-5151-change-section-component-padding-from-2rem-to-1-5rem branch from 8744ed3 to e52fa03 Compare September 18, 2024 03:59
@augustobmoura augustobmoura merged commit 38a7e47 into master Sep 18, 2024
18 checks passed
@augustobmoura augustobmoura deleted the fx-5151-change-section-component-padding-from-2rem-to-1-5rem branch September 18, 2024 04:17
@toptal-build toptal-build mentioned this pull request Sep 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants