Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4727] Remove injectFirst and styles import from TestingPicasso #4100

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jan 16, 2024

FX-4727

Description

This pull request removes Picasso.injectFirst directive as it is not relevant to testing environment and removes styles import to avoid errors like

// Staff Portal

ERROR in ../../../../node_modules/@toptal/picasso/test-utils/TestingPicasso.js 3:0-22
Module not found: Error: Can't resolve './styles.css' in '/Users/aleksandr/toptal/staff-portal/node_modules/@toptal/picasso/test-utils'
resolve './styles.css' in '/Users/aleksandr/toptal/staff-portal/node_modules/@toptal/picasso/test-utils'
  using description file: /Users/aleksandr/toptal/staff-portal/node_modules/@toptal/picasso/package.json (relative path: ./test-utils)
    Field 'browser' doesn't contain a valid alias configuration
    using description file: /Users/aleksandr/toptal/staff-portal/node_modules/@toptal/picasso/package.json (relative path: ./test-utils/styles.css)
      no extension

How to test

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Jan 16, 2024
Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: f04066e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk changed the title [FX-4727] Remove [FX-4727] Remove injectFirst and styles import from TestingPicasso Jan 16, 2024
@sashuk
Copy link
Contributor Author

sashuk commented Jan 16, 2024

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.54+f04066e7a
yarn add @toptal/picasso@42.3.5-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.5+f04066e7a
yarn add @toptal/picasso-charts@56.0.2-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.18+f04066e7a
yarn add @toptal/picasso-codemod@5.6.4-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.104+f04066e7a
yarn add @toptal/picasso-forms@66.1.3-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.18+f04066e7a
yarn add @toptal/picasso-pictograms@2.0.1-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.174+f04066e7a
yarn add @toptal/picasso-provider@3.4.4-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.5+f04066e7a
yarn add @toptal/picasso-query-builder@1.4.2-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.7+f04066e7a
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.54+f04066e7a
yarn add @toptal/picasso-shared@13.1.4-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.5+f04066e7a
yarn add @toptal/picasso-tailwind@1.0.2-alpha-FX-4727-clean-up-testing-picasso-f04066e7a.34+f04066e7a

@sashuk sashuk marked this pull request as ready for review January 16, 2024 13:25
@sashuk sashuk requested a review from a team as a code owner January 16, 2024 13:25
@sashuk
Copy link
Contributor Author

sashuk commented Jan 16, 2024

@toptal-anvil ping reviewers

@sashuk sashuk merged commit b84a938 into master Jan 17, 2024
30 of 33 checks passed
@sashuk sashuk deleted the FX-4727-clean-up-testing-picasso branch January 17, 2024 09:19
@toptal-build toptal-build mentioned this pull request Jan 17, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants