[FX-4686] Build compilation step for picasso by parts #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustobmoura
requested review from
sashuk,
dmaklygin,
TomasSlama and
mkrl
and removed request for
a team
|
augustobmoura
force-pushed
the
fx-4686-pack-all-extracted-packages-back-into-root-picasso-packages
branch
from
c23f628
to
cf200e3
Compare
augustobmoura
commented
Jan 16, 2024
There was a problem hiding this comment.
This file and the other script files might still be useful. I will remove them before merging
augustobmoura
commented
Jan 16, 2024
bin/refresh-tsconfig-references.mjs
Outdated
There was a problem hiding this comment.
This file will be merged, we need to run it from time to time to avoid need to update references manually. The script is working pretty well, as I tested it many times
TomasSlama
approved these changes
Jan 17, 2024
mkrl
reviewed
Jan 17, 2024
mkrl
approved these changes
Jan 17, 2024
augustobmoura
deleted the
fx-4686-pack-all-extracted-packages-back-into-root-picasso-packages
branch
mkrl
added a commit
that referenced
this pull request
Mar 4, 2024
* Extraction script * Extract packages with a script * Manually resolve export & type issues * [FX-4686] Build compilation step for picasso by parts (#4099) * Pack packages into picasso * Add compilation for provider and shared * Fix wrong file on main tsconfig --------- Co-authored-by: Mikhail Korolev <[email protected]> * Fix tests for base packages * Fix style imports * Fix jest mocks on base components * Fix circular barrel imports * Fix picasso-forms test errors * Fixed problems with merge with master * Add extra modules to Jest transform * Fix tests on rich text editor * Revert changes to picasso-codemod * Fix Favicon imports * Add build:all dependency to test:unit * Fix spacing & remove leftovers * Adjust Storybook and Cypress to work with split packages (#4117) * Make Cypress work and pass * Make Storybook build * Add module paths to all stories * Add reference ticket to reenable typecheck in storybook * Update Dockerfile * Update package files to fix some issues * Adjust icon generation script * Fix lint errors and build steps * Remove unused typescript check * Adjust build steps for cypress * Fix build script for provider * Fix Dockerfile * Fix Happo * Fix QueryBuilder story * Add codemod and export stubs to avoid breaking changes (#4128) * Test Alert exports field * Fix dist-package mentions * Update build folder * Update build folder in action * Revert all compiled path to dist-package * Fix old dist path in package.json * Fix build script path * Fix build script for non-ts packages * Leftower stories fixed * Export useNotifications from main utils * Remove duplicate package * Add utils stub, cleanup * Add migration codemod * Add typedefs for stubs & fix require calls * Add codemod case for imports from other Picasso packages * Add missing types and utils stub to picasso-forms * Fix Icon spec * Fix Icon paths in stories * Add missing exports from picasso and picasso-forms (#4140) --------- Co-authored-by: Augusto Moura <[email protected]> Co-authored-by: Tomáš Sláma <[email protected]> * Add changeset * Cleanup merge files * Fix broken story * Update alpha workflow --------- Co-authored-by: Augusto Moura <[email protected]> Co-authored-by: Tomáš Sláma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-4686
Description
Add build steps for the typescript compiler.
The changes are on this commit.
The changes are mainly to
package.jsonandtsconfig.json, and are pretty much copy-and-paste, I'm versioning the scripts I was using, but will remove them before merging. They might still be useful before merging the feature branch to masterHow to test
yarn build:packagefrom root, it should compile all packagesScreenshots
No screenshots
Development checks
propsin component with documentationexamplesfor componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release- Release alpha version@toptal-anvil ping reviewers- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?