Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update workflows to fetch secrets from GSM #3983

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

serbantarmure
Copy link
Contributor

@serbantarmure serbantarmure commented Nov 14, 2023

Description

CI Infrastructure is reaching the final stage of migrating all GitHub Action secrets to centralized secrets management solution: Google Secrets Manager (here you can find the whole announcement). We create PRs in automatic way and the workflows are updated according to the documentation. Each workflow is different, so we should test them and make adjustments if necessary.

The changes will not influence performance of the workflow execution.

How to test

  • run workflow(s)

CI checklist:

  • all modified workflows were tested
  • check if the secrets were fetched from GSM correctly

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: df65b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch 5 times, most recently from 11627d9 to e9d6073 Compare November 15, 2023 12:24
@serbantarmure serbantarmure self-assigned this Nov 15, 2023
@serbantarmure serbantarmure requested a review from a team November 15, 2023 12:31
@serbantarmure serbantarmure marked this pull request as ready for review November 15, 2023 12:32
@serbantarmure serbantarmure requested a review from a team as a code owner November 15, 2023 12:32
@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Nov 15, 2023
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @serbantarmure 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@serbantarmure serbantarmure force-pushed the ci-fetch-secrets-from-gsm branch 3 times, most recently from e5cd908 to 6349c7d Compare November 16, 2023 11:45
@serbantarmure serbantarmure changed the title [CI] Update workflows to fetch secrets from GSM [CI-X] Update workflows to fetch secrets from GSM Nov 16, 2023
@serbantarmure serbantarmure changed the title [CI-X] Update workflows to fetch secrets from GSM ci: update workflows to fetch secrets from GSM Nov 16, 2023
@toptal toptal deleted a comment from toptal-devbot Nov 16, 2023
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, additional testing will be done after workflow changes are merged into main branch

@sashuk sashuk merged commit e8cef2f into master Nov 16, 2023
18 of 20 checks passed
@sashuk sashuk deleted the ci-fetch-secrets-from-gsm branch November 16, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY no-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants