-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update workflows to fetch secrets from GSM #3983
Conversation
|
11627d9
to
e9d6073
Compare
Greetings from FX team, @serbantarmure 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
e5cd908
to
6349c7d
Compare
4261be6
to
38fff54
Compare
38fff54
to
df65b22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, additional testing will be done after workflow changes are merged into main branch
Description
CI Infrastructure is reaching the final stage of migrating all GitHub Action secrets to centralized secrets management solution: Google Secrets Manager (here you can find the whole announcement). We create PRs in automatic way and the workflows are updated according to the documentation. Each workflow is different, so we should test them and make adjustments if necessary.
The changes will not influence performance of the workflow execution.
How to test
CI checklist: