-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aa #3660
fix: aa #3660
Conversation
* feat: add Toolbar for LexicalEditor * chore: review amends
* chore: integrate disable state * fix: reexport change handler type * chore: update tests for Lexical editor * fix: rte test * fix: fix review comments
* chore: integrate limits to rich text editor * chore: update tests
* chore: integrate new rich text editor to forms * chore: add highlight prop * chore: enhance component * chore: remove unnecessary tests cases
* chore: integrare onFocus and onBlur plugins to RTE * chore: remove outdated props * chore: add Focus and autoFocus functionality * chore: cover with unit tests a new hook
|
cb2938b
to
14df3bd
Compare
14df3bd
to
6798447
Compare
4162f58
to
a4d7ffe
Compare
FX-4106
🔴 Please do not review
Description
Describe the changes and motivations for the pull request.
Approaches
PicassoTextNode
that has a modifiedexportDOM()
class method that does not wrap elements in<b/>
, for example (as it is done inTextNode
here)$createTextNode()
function which createsTextNode
, not thePicassoTextNode
registerNodeTransform()
that replacesTextNodes
withPicassoTextNode
(❓ somehow the formatting does not work in this case)How to test
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?