-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rich text editor behaviour in forms #3656
Conversation
|
4331044
to
b51f4c5
Compare
@@ -52,11 +52,13 @@ describe('replaceHeadingNodes', () => { | |||
) | |||
|
|||
const appendMock = jest.fn() | |||
const selectMock = jest.fn() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was broken in feature branch, not related to the bug
@toptal-anvil ping reviewers |
FX-4105
Description
This pull request fixes bug with Rich Text Editor blocking the form, so the RTE field does not lose focus (bug was introduced in #3645).
The solution is to move the
registerNodeTransform()
in the separate plugin.How to test
Steps to reproduce
yarn start
Navigate to https://picasso.toptal.net/FX-NULL-fix-rte-in-forms/?path=/story/picasso-forms-form--form and test it the same way
Screenshots
🔴 Before
Kapture.2023-06-26.at.19.27.28.mp4
🟢 After
Kapture.2023-06-26.at.20.08.51.mp4
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?