Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichTextEditor): add Emoji plugin #3653

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Jun 26, 2023

FX-4012

Description

  • Create context to enable/disable optional features
  • Add emoji plugin

How to test

Screenshots

Before. After.
image image

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama requested a review from a team as a code owner June 26, 2023 11:58
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: 41f1d6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TomasSlama TomasSlama changed the base branch from master to feature/rte-lexical June 26, 2023 11:59
@TomasSlama TomasSlama self-assigned this Jun 26, 2023
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 12:12 Inactive
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy June 27, 2023 08:39 Inactive
@TomasSlama TomasSlama requested review from sashuk and a team June 27, 2023 13:39
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy June 27, 2023 13:51 Inactive
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but didn't tested them yet

@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy June 28, 2023 14:36 Inactive
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments, but it seems like its working correctly. One note though, should undo and redo be working on this? Or is this a different feature for a different ticket?

@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy June 29, 2023 10:56 Inactive
@TomasSlama TomasSlama merged commit 4162f58 into feature/rte-lexical Jun 29, 2023
8 of 9 checks passed
@TomasSlama TomasSlama deleted the FX-4012-emoji branch June 29, 2023 14:04
augustobmoura pushed a commit that referenced this pull request Jun 29, 2023
dmaklygin pushed a commit that referenced this pull request Jul 3, 2023
dmaklygin pushed a commit that referenced this pull request Jul 5, 2023
dmaklygin pushed a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants