-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RichTextEditor): add Emoji plugin #3653
Conversation
|
96f8fd2
to
248ea7b
Compare
@toptal-anvil ping reviewers |
packages/picasso/src/LexicalEditor/context/SettingsContext.test.tsx
Outdated
Show resolved
Hide resolved
packages/picasso/src/LexicalEditor/utils/synchronizeToolbarState.test.ts
Outdated
Show resolved
Hide resolved
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but didn't tested them yet
packages/picasso/src/LexicalEditor/utils/registerLexicalEvents.ts
Outdated
Show resolved
Hide resolved
7e36842
to
6eaffc4
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments, but it seems like its working correctly. One note though, should undo and redo be working on this? Or is this a different feature for a different ticket?
packages/picasso/src/LexicalEditor/utils/synchronizeToolbarState.test.ts
Outdated
Show resolved
Hide resolved
packages/picasso/src/LexicalEmojiPlugin/nodes/CustomEmojiNode.tsx
Outdated
Show resolved
Hide resolved
packages/picasso/src/LexicalEmojiPlugin/nodes/CustomEmojiNode.tsx
Outdated
Show resolved
Hide resolved
packages/picasso/src/LexicalEmojiPlugin/nodes/CustomEmojiNode.tsx
Outdated
Show resolved
Hide resolved
@toptal-anvil ping reviewers |
9ec3477
to
41f1d6b
Compare
FX-4012
Description
How to test
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?