Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FX-4053] move rich text editor to a separate package #3637

Merged
merged 6 commits into from
Jun 28, 2023
Merged

feat: [FX-4053] move rich text editor to a separate package #3637

merged 6 commits into from
Jun 28, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Jun 19, 2023 •
edited
Loading

FX-4053

Description

We have to move RTE to a separate package to provide customers more flexibility

How to test

  • use alpha version in Staff Portal

Use this PR to test

Development checks

  • Add changeset according to guidelines (if needed)
  • Ensure that deployed demo has expected results and good examples
  • Self reviewed

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@dmaklygin dmaklygin self-assigned this Jun 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 18f042b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@toptal/picasso-codemod Minor
@toptal/picasso Major
@toptal/picasso-forms Major
@toptal/picasso-charts Major
@toptal/picasso-rich-text-editor Major
@topkit/analytics-charts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dmaklygin
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@dmaklygin dmaklygin force-pushed the fx-4053-create-separate-package-for-rte branch from 8c7e408 to e2980e9 Compare June 19, 2023 15:16
@dmaklygin
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@46.0.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.13+e2980e91b
yarn add @toptal/picasso@35.2.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.1+e2980e91b
yarn add @toptal/picasso-charts@49.0.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.13+e2980e91b
yarn add @toptal/picasso-codemod@5.4.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.182+e2980e91b
yarn add @toptal/picasso-forms@57.0.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.13+e2980e91b
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.15+e2980e91b
yarn add @toptal/picasso-provider@3.1.3-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.4+e2980e91b
yarn add @toptal/picasso-rich-text-editor@1.0.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.3636+e2980e91b
yarn add @toptal/picasso-shared@12.0.1-alpha-fx-4053-create-separate-package-for-rte-e2980e91b.60+e2980e91b

@toptal-devbot toptal-devbot temporarily deployed to temploy June 19, 2023 15:25 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 19, 2023 15:39 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 19, 2023 18:14 Inactive
@dmaklygin
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@46.0.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.17+ce7a047c8
yarn add @toptal/picasso@35.2.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.5+ce7a047c8
yarn add @toptal/picasso-charts@49.0.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.17+ce7a047c8
yarn add @toptal/picasso-codemod@5.4.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.186+ce7a047c8
yarn add @toptal/picasso-forms@57.0.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.17+ce7a047c8
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.19+ce7a047c8
yarn add @toptal/picasso-provider@3.1.3-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.8+ce7a047c8
yarn add @toptal/picasso-rich-text-editor@1.0.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.3640+ce7a047c8
yarn add @toptal/picasso-shared@12.0.1-alpha-fx-4053-create-separate-package-for-rte-ce7a047c8.64+ce7a047c8

@toptal-devbot toptal-devbot temporarily deployed to temploy June 19, 2023 18:26 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 19, 2023 18:49 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 20, 2023 12:39 Inactive
@dmaklygin dmaklygin marked this pull request as ready for review June 21, 2023 09:54
@dmaklygin dmaklygin requested a review from a team as a code owner June 21, 2023 09:55
@toptal-devbot toptal-devbot temporarily deployed to temploy June 21, 2023 10:06 Inactive
@dmaklygin dmaklygin force-pushed the fx-4053-create-separate-package-for-rte branch from 9e3492e to 9322503 Compare June 23, 2023 11:20
@toptal-devbot toptal-devbot temporarily deployed to temploy June 23, 2023 11:30 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 08:41 Inactive
@dmaklygin dmaklygin force-pushed the fx-4053-create-separate-package-for-rte branch from 46afb3b to e1da28e Compare June 26, 2023 15:40
@dmaklygin
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@46.0.1-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.22+e1da28eb4
yarn add @toptal/picasso@35.2.4-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.1+e1da28eb4
yarn add @toptal/picasso-charts@49.0.1-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.22+e1da28eb4
yarn add @toptal/picasso-codemod@5.4.2-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.6+e1da28eb4
yarn add @toptal/picasso-forms@57.0.1-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.22+e1da28eb4
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.24+e1da28eb4
yarn add @toptal/picasso-provider@3.1.3-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.13+e1da28eb4
yarn add @toptal/picasso-rich-text-editor@1.0.2-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.1+e1da28eb4
yarn add @toptal/picasso-shared@12.0.1-alpha-fx-4053-create-separate-package-for-rte-e1da28eb4.69+e1da28eb4

@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 15:52 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 20:56 Inactive
TomasSlama
TomasSlama approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.changeset/tender-poems-beg.md Outdated Show resolved Hide resolved
.changeset/tender-poems-editor.md Outdated Show resolved Hide resolved
.changeset/tender-poems-editor.md Outdated Show resolved Hide resolved
augustobmoura
augustobmoura approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like everything is working, didn't catch any possible errors

@dmaklygin
chore: fix tests
dcb3307
@dmaklygin
feat: [FX-4053] create codemods for RTE (#3657)
8b24606 
* chore: create codemods for rte

* chore: adjust codemod

* chore: update eslint rules for codemod

* chore: update eslintignore

* chore: update prettier ignore

* chore: update version
@dmaklygin
chore: update the changeset
6e657b2
@dmaklygin dmaklygin force-pushed the fx-4053-create-separate-package-for-rte branch from b233965 to 6e657b2 Compare June 28, 2023 13:19
@toptal-devbot toptal-devbot temporarily deployed to temploy June 28, 2023 13:31 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 28, 2023 14:03 Inactive
@dmaklygin dmaklygin merged commit d4795a8 into master Jun 28, 2023
12 checks passed
@dmaklygin dmaklygin deleted the fx-4053-create-separate-package-for-rte branch June 28, 2023 14:05
@toptal-build toptal-build mentioned this pull request Jun 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustobmoura augustobmoura augustobmoura approved these changes

@TomasSlama TomasSlama TomasSlama approved these changes

Assignees

@dmaklygin dmaklygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaklygin @toptal-devbot @augustobmoura @TomasSlama