Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Consider and explore redux-style reducer approach for stats #10

Open
cabiad opened this issue Nov 15, 2018 · 1 comment
Open

Consider and explore redux-style reducer approach for stats #10

cabiad opened this issue Nov 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@cabiad
Copy link
Contributor

cabiad commented Nov 15, 2018

I tend to agree that following the stats flow through the code is a little unclear. Maybe this would help.

See #1 (comment)

just a random comment: what about exploring a redux-style reducer approach for stats, where a visitor would receive the node and the top-level stats tree as arguments and return a new stats object?

@cabiad cabiad added the enhancement New feature or request label Nov 15, 2018
@cabiad cabiad mentioned this issue Nov 15, 2018
4 tasks
@cabiad
Copy link
Contributor Author

cabiad commented Nov 15, 2018

see also #1 (comment)

just a random comment: what about exploring a redux-style reducer approach for stats, where a visitor would receive the node and the top-level stats tree as arguments and return a new stats object?

@francoiscampbell yeah I like the redux idea. Although this breaks the ast.NodeVisitor api compatibility. I'm not sure how much we desire this compatibility as a feature though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant