Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget Version Outdated: Topgrade 14.0.1 Instead of 16.0.1 #958

Open
niStee opened this issue Oct 16, 2024 · 6 comments
Open

Winget Version Outdated: Topgrade 14.0.1 Instead of 16.0.1 #958

niStee opened this issue Oct 16, 2024 · 6 comments
Labels
C-bug Something isn't working

Comments

@niStee
Copy link
Contributor

niStee commented Oct 16, 2024

Erroneous Behavior

The version of Topgrade in Winget is 14.0.1 instead of the current release level 16.0.1.

Expected Behavior

The version of Topgrade in Winget should match the latest release version, which is 16.0.1.

Steps to reproduce

  1. Check the version of Topgrade available in Winget by running winget show topgrade, or https://winstall.app/apps/topgrade-rs.topgrade.
  2. Compare it with the latest release version on the Topgrade GitHub releases page https://github.com/topgrade-rs/topgrade/releases/.

Possible Cause (Optional)

The .github/workflows/update_winget.yml workflow may not be correctly configured to update the Winget package with the latest version.

@niStee niStee added the C-bug Something isn't working label Oct 16, 2024
@SteveLauC
Copy link
Member

Indeed, thanks for bringing this to our attention!

Here is the log of that action:

if (-not $?) {
    Write-Output "::error::Package $PkgId does not exist in the winget-pkgs repository. Please add atleast one version of the package before using this action."
    exit 1
  }

@niStee
Copy link
Contributor Author

niStee commented Oct 16, 2024

I will look into it.

@soredake
Copy link

Any progress on this?

@niStee
Copy link
Contributor Author

niStee commented Nov 2, 2024

Any progress on this?

#976

@niStee
Copy link
Contributor Author

niStee commented Nov 2, 2024

Indeed, thanks for bringing this to our attention!

Here is the log of that action:

if (-not $?) {
    Write-Output "::error::Package $PkgId does not exist in the winget-pkgs repository. Please add atleast one version of the package before using this action."
    exit 1
  }

@SteveLauC, the following may be the problem here vedantmgoyal9/winget-releaser#309 (comment), any suggestions on how to fix this?

@SteveLauC
Copy link
Member

SteveLauC commented Nov 3, 2024

the following may be the problem here vedantmgoyal9/winget-releaser#309 (comment), any suggestions on how to fix this?

Honestly, I don't think I understand this issue. But per the README, looks like we don't need to use fork-user input?

Fork microsoft/winget-pkgs under the same account/organization as the project's repository. If you are forking winget-pkgs on a different account (e.g. bot/personal account), you can use the fork-user input to specify the username of the account where the fork is present.

I do find something strange, our winget-pkgs is fork not up-to-date with the upstream repo(I just manually gave it an update), it is possibly because this:

GitHub actually has reached out to me specifically about the winget-pkgs repo and its forks causing some issues within their backend systems which could be the cause of failed merges which has downstream effects on Pull.

Though I have no idea if this could lead to a failed release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants