Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doom Emacs added AOT compile support #884

Open
raszi opened this issue Aug 9, 2024 · 3 comments
Open

Doom Emacs added AOT compile support #884

raszi opened this issue Aug 9, 2024 · 3 comments
Labels
C-feature request New feature request

Comments

@raszi
Copy link

raszi commented Aug 9, 2024

I want to suggest a new option

To enable the AOT compilation option for the doom upgrade command.

More information

@hlissner added AOT compilation option for the sync and upgrade commands. It would be great if Topgrade would support that.

doomemacs/doomemacs@e3fdfee

@raszi raszi added the C-feature request New feature request label Aug 9, 2024
@SteveLauC
Copy link
Member

Hi, sorry for the late reply.

In the commit message:

(This is a stop-gap solution until the v3.0 release)

Does the sentence mean that this AOT feature is a workaround and will be replaced by something else in version 3.0?

@hlissner
Copy link

Does the sentence mean that this AOT feature is a workaround and will be replaced by something else in version 3.0?

I meant that the implementation will change, but the --aot option is a permanent fixture of doom sync and doom upgrade going forward.

@SteveLauC
Copy link
Member

I meant that the implementation will change, but the --aot option is a permanent fixture of doom sync and doom upgrade going forward.

Get it, thanks for the explanation, let's impl this feature in Topgrade!

Should we add this option by default or make it optional and configurable 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature request New feature request
Projects
None yet
Development

No branches or pull requests

3 participants