Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Settings - Textinput triggers writeconfig after each key hit #23

Open
henryk86 opened this issue Apr 30, 2024 · 3 comments
Open

Edit Settings - Textinput triggers writeconfig after each key hit #23

henryk86 opened this issue Apr 30, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request fixed in develop

Comments

@henryk86
Copy link
Collaborator

henryk86 commented Apr 30, 2024

Currenlty each keyhit in a settings textinput (numberinput) triggers the triggerWriteConfig function. This should be changed, if possible, it should only be triggered if user has finished with his input.

If you type fast, this lets crash your teddycloud / destroys the config.overlay.ini in toniebox mgmt settings.

@henryk86
Copy link
Collaborator Author

This should be solved asap. If you change a directory setting. It creates a folder with each key hitting.

IMG_0426

@henryk86
Copy link
Collaborator Author

As a intermediate solution the textinput got a save button. Instead of firing the api with every key , user must now save this type of inputfield manually.

@henryk86 henryk86 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Oct 8, 2024
@henryk86
Copy link
Collaborator Author

First version started by @naymecliff is finished and ready to be merged and tested.

@henryk86 henryk86 added fixed in develop and removed help wanted Extra attention is needed labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request fixed in develop
Projects
None yet
Development

No branches or pull requests

1 participant