Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect notifications in extra section #165

Open
SciLor opened this issue Nov 4, 2024 · 9 comments
Open

Collect notifications in extra section #165

SciLor opened this issue Nov 4, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request fixed in develop

Comments

@SciLor
Copy link
Contributor

SciLor commented Nov 4, 2024

Collect notifications in extra section, to review errors and success messages to review past messages.
Maybe in the style portalner does.

@SciLor SciLor added the enhancement New feature or request label Nov 4, 2024
@henryk86
Copy link
Collaborator

henryk86 commented Nov 4, 2024

Antd Notification could be the thing for that. Tinkering around them for a while.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 4, 2024

Can you post a screen from portainer? I do not have that installed

@SciLor
Copy link
Contributor Author

SciLor commented Nov 4, 2024

Screenshot_20241104-211544
Screenshot_20241104-211605~2
Screenshot_20241104-211630~2

@henryk86
Copy link
Collaborator

henryk86 commented Nov 5, 2024

How to store the notifications? If I hit f5, they will be lost. I do not see a frontend only solution for that beside storing them in the local storage of the browser? Or would this be the way to go?

@henryk86
Copy link
Collaborator

henryk86 commented Nov 5, 2024

something like:

image

@henryk86
Copy link
Collaborator

henryk86 commented Nov 5, 2024

and a list...

image

@henryk86
Copy link
Collaborator

henryk86 commented Nov 6, 2024

decisions:

  • notifications will be stored in local storage (so currently not available cross browsers/devices/http-https)
  • Success + info are confirmed by default, but can be marked as unconfirmed on creation
  • Warning + error are unconfirmed by default, but can also be marked as confirmed on creation

To do:

  • Move messages to notifications
    • all messages moved to notifications - DONE BUT except the settings page ones
  • Add translations - DONE
  • Add remove all button to notification list - DONE
  • Add single/multi delete / single/multi confirm to notification list - DONE
  • Add icons to notification list entries - DONE
  • Add context to notifications (like system, tonies, tonieboxes, settings, general, …) - DONE
  • Add search in notification list - DONE
  • Add more filter to notification list - DONE
  • Mobile support - DONE

@henryk86
Copy link
Collaborator

henryk86 commented Nov 6, 2024

image

@henryk86 henryk86 self-assigned this Nov 7, 2024
@henryk86
Copy link
Collaborator

henryk86 commented Nov 8, 2024

Toniecard: change source: title shows {{selectedSource}} - replace not working

but short title message in general

—> done in English, but forgotten in at least German. Translation needs to be checked

--> checked & fixed

SciLor added a commit that referenced this issue Nov 12, 2024
gh-165 finalized Migration Messages to notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in develop
Projects
None yet
Development

No branches or pull requests

2 participants