Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPSemVerChecker\Comparator\Type::get does not support PhpParser\Node\UnionType #179

Open
danmooney2 opened this issue Apr 12, 2023 · 1 comment
Open

PHPSemVerChecker\Comparator\Type::get does not support PhpParser\Node\UnionType #179

danmooney2 opened this issue Apr 12, 2023 · 1 comment

Comments

@danmooney2
Copy link

PHPSemVerChecker\Comparator\Type::get method does not check for instanceof PhpParser\Node\UnionType. toString method is not present on PhpParser\Node\UnionType or any other ComplexType, hence why a change was made here to specifically support NullableType. This should be updated to support all complex types introduced by PhpParser.
@danmooney2
Copy link
Author

Are you going to reference the commit that fixes this issue? How dead is this project on a scale of 1-10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danmooney2