Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show video quality settings on iPad #378

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Shingyx
Copy link
Contributor

@Shingyx Shingyx commented Aug 16, 2024

Fixes #341

Example screenshot of the video player on iPad, using the custom overlay with "Default to highest quality" enabled.

@Shingyx Shingyx changed the title Show iPad quality settings on iPad Show video quality settings on iPad Aug 16, 2024
@tommyxchow tommyxchow self-assigned this Aug 16, 2024
@tommyxchow tommyxchow added ios Specific to iOS new feature An addition that does not already exist labels Aug 16, 2024
Copy link
Owner

@tommyxchow tommyxchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@tommyxchow tommyxchow merged commit c022db9 into tommyxchow:main Aug 16, 2024
1 check passed
@Shingyx Shingyx deleted the ipad-stream-quality branch August 16, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ios Specific to iOS new feature An addition that does not already exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable stream quality selection with custom overlay on iPads
2 participants