-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the history navigation buttons #396
Comments
Hi, I would like to work on this issue. |
Thanks, I'll try my best to implement this. |
@abhishek-singh0710 thanks for pointing this out, lock file needed updates for new python version. Now the error has been resolved in #407 |
I've installed Rust and have put cargo in my path variables also |
@abhishek-singh0710 this seems to be a common issue as it's listed in many times in the web. I was able to reproduce this issue with python Since 3.13 is very new, pywinpty hasn't provide the wheels yet. See andfoy/pywinpty#451 I'm marking this project as unsupported for |
Just a heads up, this is the case for |
@abhishek-singh0710 issue has been resolved. pywinpty now supports python 3.13. |
@abhishek-singh0710 Hello there, as the issue is still assigned to you, I would like to know if you are still working on this. Please open a pr if you have worked on this otherwise I can unassign the issue :) |
is this still open? i would love to give it a try |
@vyshnav-vinod Yes this is, I guess the assignee doesn't want to continue working on this anymore as they didn't respond to any of the comments. You can give it a try. |
is this supposed to be the current editor instance only(so different history for each editor tab) or does it include maintaining a single history across the editor tabs (like in vs code)?? |
@vyshnav-vinod I think it would make sense to keep a single history across all the tabs, that would make it more usable. But also you may keep a max size to that history. Just clean up old chunks when it's full. |
@vyshnav-vinod the idea were to have those lookalike buttons for two purposes:
Although the former doesn't have a big use case, when you have many tabs open, it's just impossible to access them. You can use the right one to handle history navigation. |
Hey so i tried to start this, how would you like to record the cursor postions.. i havent really used vscodes cursor navigation and thought to try it today, it seems they are only recording the first cursor position in a file or something? How would you like to record it? I was thinking of just recording the cursor positions when the user does a huge jump (like either tab switches or after n number of code lines from previous position?). Please let me know if i make no sense :). |
@vyshnav-vinod I guess we can just directly store the cursor positions changes on mouse clicks and maybe tab switches for now, no need to check for any n number of lines. Key presses combined with a check for code lines sounds a bit overhead for tkinter, especially since those already require optimizations due to completions and syntax highlight updates. |
Feature
The history navigations are placed next to breadcrumbs
These shall navigate user's cursor positions
Notes
self.base.editorsmanager.active_editor
. Note that theactive_editor.content
will be the TextEditor instance andactive_editor.content.text
will be the Text widget instance.The text was updated successfully, but these errors were encountered: